[illumos-Developer] [REVIEW] 825 Would like SMF critical restart rate to be configurable

Garrett D'Amore garrett at nexenta.com
Fri Mar 18 15:16:33 PDT 2011


On Fri, 2011-03-18 at 18:15 -0400, Dan McDonald wrote:
> On Fri, Mar 18, 2011 at 02:00:29PM -0700, John Sonnenschein wrote:
> > Hey, I'd like review for 
> > 
> >  825 Would like SMF critical restart rate to be configurable
> > 
> > webrev here: http://siralos.org/smf/
> 
> Small nit:
> 
> 	- Can't you put &scr_fr and &scf_st into the propvec initializer
> 	  itself?  Or does that break certain compilation environments?
> 
> Otherwise, looks good.

I had the same thought... but I wasn't sure if the compiler would
initialize the structure properly that way.

	- Garrett

> 
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list