[illumos-Developer] [REVIEW] 825 Would like SMF critical restart rate to be configurable
John Sonnenschein
johnsonnenschein at gmail.com
Fri Mar 18 15:31:47 PDT 2011
On Mar 18, 2011, at 3:15 PM, Dan McDonald wrote:
> On Fri, Mar 18, 2011 at 02:00:29PM -0700, John Sonnenschein wrote:
>> Hey, I'd like review for
>>
>> 825 Would like SMF critical restart rate to be configurable
>>
>> webrev here: http://siralos.org/smf/
>
> Small nit:
>
> - Can't you put &scr_fr and &scf_st into the propvec initializer
> itself? Or does that break certain compilation environments?
>
> Otherwise, looks good.
That only works if they're static (IIRC) but either way the compiler complains so they needed to be moved out
-JohnS
More information about the Developer
mailing list