[illumos-Developer] Webrev: New ARECA arcmsr driver

Dan McDonald danmcd at nexenta.com
Thu Mar 24 10:41:04 PDT 2011


On Thu, Mar 24, 2011 at 09:57:55AM -0700, Garrett D'Amore wrote:
> All of these changes are small, and hopefully low risk changes.
> 
> The new webrev is here: 
> 
> http://mexico.purplecow.org/gdamore/webrev/arcmsr-delta/

Only nit in arcmsr.h:  You nuked this field:

 854         int                     tgt_scsi_opts[ARCMSR_MAX_TARGETID];

but I'm not sure why.

In arcmsr.c:

	- You still have the stupid memcpy(src, dst, 1); calls, even though
          you fixed stuff around it.

Other than that, ship it.

Dan



More information about the Developer mailing list