[illumos-Developer] Changing sd_io_time to 8?

[Garrett D'Amore]

On Tue, 2011-05-03 at 12:32 -0400, Dan McDonald wrote:
> On Tue, May 03, 2011 at 05:22:32PM +0100, Deano wrote:
> 
> <SNIP!>
> 
> > It is exactly this kind of confusion, which is why I believe why SD is
> > overburdened, also from the source code which at IIRC 13K+ LOC is well
> > above most software engineering thoughts on file size indicates it to me.
> 
> Well SOMETHING had to take the place of ip.c as biggest source file in the
> kernel.  ;)

Oh, I can probably think of several bigger files, and certainly bigger
*drivers*.

None of which means this is a good example to follow.  There is no
reason that sd should be more than about 5 or 6KLOC -- except that it is
filled with logic for too many different types of devices, and to deal
with too many exceptions.

I've contemplated a major overhaul of this driver in the past.

If nothing else, the tunable mechanism is so arcanely byzantine, that
nobody can reasonably use it without spending time reading the code --
yet there are a significant number of things in that driver that you
really *do* want to tune for different types of devices.

	- Garrett
> 
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer