[illumos-Developer] webrev: 650 grep support for -q would be useful

Richard Lowe richlowe at richlowe.net
Thu May 5 11:05:24 PDT 2011


> At least one grep invocation in usr/src/tools/scripts/nightly.sh has to
> be changed - the one with '|%WHOANDWHERE|', either escape |'s or don't
> use egrep (just grep should do fine there, not sure why egrep was used
> everywhere in that file).

I did some digging for Yuri, and the only '%WHOANDWHERE%' I could find
is the Version strings in libldap4.  My only guess was that we used to
expand the %...% sections and needed to keep the pattern strings out
of the noise.  It's just a guess though.

> A diff for nightly.sh with a lot more changes
> making sure we call just `grep` while we are here:
>
> https://www.xvoid.org/illumos/stuff/nightly.sh.diff
>

It seems like using 'grep -E' in these diffs as you do would cause
problems for people using nightly but not yet having your grep changes
installed on their build machine.  You need to keep using 'egrep' in
those cases for a while (note that nightly forces a $PATH such that
/usr/bin precedes the other directories containing grep commands).

-- Rich



More information about the Developer mailing list