[illumos-Developer] Code Review: WRITE_SAME support for COMSTAR's stmf_sbd

[Richard Elling]

On May 18, 2011, at 8:21 AM, Dan McDonald wrote:

> As with the UNMAP support, this came courtesy of Sumit Gupta.  Unlike UNMAP,
> these changes are localized to implementing a full version of the WRITE_SAME
> SCSI command, so they won't mess with ZFS calls the way UNMAP did.  I hope
> this will yield less controversy than the original UNMAP diffs.

Looks pretty good.

I'd like to see a dtrace probe around the actual I/O, sbd_scsi.c line 2307
so we can measure how long the actual write same I/O takes.
 -- richard

> 
> Regardless of my hope, please review and be as brutal as you wish.  These
> changes are mostly just another command handler.
> 
> 	http://www.kebe.com/~danmcd/webrevs/write-same/
> 
> Thank you!
> Dan
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer