[illumos-Developer] review request - webrev for #952 separate intent logs should be obvious in 'zpool iostat' output

Mike Harsch mike at harschsystems.com
Mon May 23 20:43:02 PDT 2011


On 5/23/11 6:25 PM, Dan McDonald wrote:
> I notice you now (void)-cast the returns from nvlist_lookup_uint64().  The
> old code check the return value.  Is this a feature or a bug?
There are examples of doing this both ways within the same file 
(zpool_main.c).  The logic you're referring to is basically lifted 
straight from the 'zpool status' codepath, where logs are properly 
filtered along with holes (see line 1165).

Mike



More information about the Developer mailing list