[illumos-Developer] review request - webrev for #952 separate intent logs should be obvious in 'zpool iostat' output
Garrett D'Amore
garrett at damore.org
Mon May 23 22:26:07 PDT 2011
Line 2104; "logs" is not subject to translation. (This is true for "cache" a little later, and possibly other aspects of this output, which I've not looked at.)
I think I'd like an RFE to make zpool i18n aware. (Use gettext() for these fixed strings.) But otherwise the code itself looks good to me.
-- Garrett D'Amore
On May 24, 2011, at 4:06 AM, Mike Harsch <mike at harschsystems.com> wrote:
> Requesting review for proposed fix:
> Bug #952 separate intent logs should be obvious in 'zpool iostat' output
> https://www.illumos.org/issues/952
>
> webrev is here:
> http://harschsystems.com/bugs/illumos-952-webrev/
>
> The above webrev has been reviewed by Adam Leventhal and Matt Ahrens.
>
> Test results showing the changes in 'zpool iostat -v' output:
>
> single device pool with one log:
>
> current -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> foopool 1.08G 927G 0 655 0 70.0M
> c2t3d0s0 1.08G 927G 0 564 0 69.0M
> c7t0d0p0 8.27M 3.71G 0 90 0 1.07M
> ---------- ----- ----- ----- ----- ----- -----
>
> new -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> foopool 1.11G 927G 0 770 0 67.2M
> c2t3d0s0 1.11G 927G 0 575 0 64.9M
> logs - - - - - -
> c7t0d0p0 10.7M 3.71G 0 194 0 2.28M
> ---------- ----- ----- ----- ----- ----- -----
>
>
> pool with mirrored logs:
>
> current -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> barpool 1.16G 927G 0 277 0 11.4M
> c2t3d0 1.16G 927G 0 85 0 9.12M
> mirror 15.6M 3.70G 0 191 0 2.25M
> c6t0d0p0 - - 0 191 0 2.25M
> c7t0d0p0 - - 0 191 0 2.25M
> ---------- ----- ----- ----- ----- ----- -----
>
> new -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> barpool 1.16G 927G 0 185 0 2.18M
> c2t3d0 1.16G 927G 0 0 0 0
> logs - - - - - -
> mirror 16.3M 3.70G 0 185 0 2.18M
> c6t0d0p0 - - 0 185 0 2.18M
> c7t0d0p0 - - 0 185 0 2.18M
> ---------- ----- ----- ----- ----- ----- -----
>
> pool with log devs and cache devs:
>
> current -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> bazpool 1.05G 927G 0 472 0 30.7M
> c2t3d0 1.05G 927G 0 284 0 28.5M
> c6t0d0p0 2.58M 3.72G 0 93 0 1.10M
> c7t0d0p0 2.57M 3.72G 0 93 0 1.10M
> cache - - - - - -
> c1t0d0p0 159M 3.58G 0 13 0 1.75M
> ---------- ----- ----- ----- ----- ----- -----
>
> new -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> bazpool 1.08G 927G 0 207 0 2.39M
> c2t3d0 1.08G 927G 0 3 0 3.99K
> logs - - - - - -
> c6t0d0p0 4.09M 3.71G 0 101 0 1.19M
> c7t0d0p0 4.09M 3.71G 0 101 0 1.19M
> cache - - - - - -
> c1t0d0p0 223M 3.51G 0 49 0 6.24M
> ---------- ----- ----- ----- ----- ----- -----
>
> multiple pools with log devs:
>
> current -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> poolone 1.04G 98.5G 4 5 639K 71.9K
> mirror 1.04G 98.5G 4 0 639K 0
> c2t3d0s0 - - 2 3 383K 3.99K
> c2t3d0s1 - - 1 3 256K 3.99K
> c1t0d0p0 2.02M 3.72G 0 2 0 36.0K
> c7t0d0p0 2.00M 3.72G 0 2 0 36.0K
> ---------- ----- ----- ----- ----- ----- -----
> pooltwo 1.62G 296G 0 269 0 2.81M
> raidz1 1.62G 296G 0 62 0 400K
> c2t3d0s2 - - 0 34 0 206K
> c2t3d0s3 - - 0 192 0 19.3M
> c2t3d0s4 - - 0 192 0 19.3M
> c5t0d0p0 7.51M 3.71G 0 206 0 2.42M
> cache - - - - - -
> c3t0d0p0 251M 7.21G 0 49 0 6.24M
> ---------- ----- ----- ----- ----- ----- -----
>
> new -
> capacity operations bandwidth
> pool alloc free read write read write
> ---------- ----- ----- ----- ----- ----- -----
> poolone 1.02G 98.5G 2 53 383K 123K
> mirror 1.02G 98.5G 2 49 383K 75.4K
> c2t3d0s0 - - 1 36 256K 76.9K
> c2t3d0s1 - - 0 38 128K 79.4K
> logs - - - - - -
> c1t0d0p0 792K 3.72G 0 1 0 24.0K
> c7t0d0p0 792K 3.72G 0 1 0 24.0K
> ---------- ----- ----- ----- ----- ----- -----
> pooltwo 1.63G 296G 0 250 0 2.89M
> raidz1 1.63G 296G 0 51 0 574K
> c2t3d0s2 - - 0 204 0 21.0M
> c2t3d0s3 - - 0 57 0 3.04M
> c2t3d0s4 - - 0 31 0 295K
> logs - - - - - -
> c5t0d0p0 8.04M 3.71G 0 198 0 2.33M
> cache - - - - - -
> c3t0d0p0 442M 7.02G 0 53 0 6.13M
> ---------- ----- ----- ----- ----- ----- -----
>
> multiple log mirrors:
>
> current -
> capacity operations bandwidth
> pool alloc free read write read write
> ------------ ----- ----- ----- ----- ----- -----
> rpool 14.3G 134G 0 0 0 0
> c2t0d0s0 14.3G 134G 0 0 0 0
> ------------ ----- ----- ----- ----- ----- -----
> tank 1.00G 98.5G 0 488 0 35.4M
> mirror 1.00G 98.5G 0 316 0 33.4M
> c2t3d0s0 - - 0 313 0 37.7M
> c2t3d0s1 - - 0 272 0 33.4M
> mirror 0 3.72G 0 85 0 1.01M
> c1t0d0p0 - - 0 85 0 1.01M
> c3t0d0p0 - - 0 85 0 1.01M
> mirror 4K 3.72G 0 85 0 1.01M
> c4t0d0p0 - - 0 85 0 1.01M
> c5t0d0p0 - - 0 85 0 1.01M
> cache - - - - - -
> c7t0d0p0 261M 3.47G 0 21 0 2.75M
> ------------ ----- ----- ----- ----- ----- -----
>
> new -
> capacity operations bandwidth
> pool alloc free read write read write
> ------------ ----- ----- ----- ----- ----- -----
> rpool 14.3G 134G 0 0 0 0
> c2t0d0s0 14.3G 134G 0 0 0 0
> ------------ ----- ----- ----- ----- ----- -----
> tank 1.04G 98.5G 0 471 0 17.0M
> mirror 1.04G 98.5G 0 293 0 14.9M
> c2t3d0s0 - - 0 190 0 14.9M
> c2t3d0s1 - - 0 169 0 12.6M
> logs - - - - - -
> mirror 1.80M 3.72G 0 88 0 1.04M
> c1t0d0p0 - - 0 87 0 1.03M
> c3t0d0p0 - - 0 89 0 1.05M
> mirror 1.82M 3.72G 0 88 0 1.04M
> c4t0d0p0 - - 0 88 0 1.04M
> c5t0d0p0 - - 0 88 0 1.04M
> cache - - - - - -
> c7t0d0p0 327M 3.41G 0 57 0 7.24M
> ------------ ----- ----- ----- ----- ----- -----
>
>
>
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
More information about the Developer
mailing list