[illumos-Developer] CODE REVIEW --> #935, sv_lyr_open() uses NULL pointers...

[Adam Leventhal]

Hey Dan,

You've changed some boolean uses of svp to be svp != NULL, but there
are several other places in the function that you didn't change. I'd
argue for consistency one way or the other (and probably within the
file).

But the code itself looks good.

Adam

On Wed, Apr 20, 2011 at 7:46 AM, Dan McDonald <danmcd at nexenta.com> wrote:
> A Nexenta customer found this, and Nexenta's own Yuri Pankov proved the
> problem is also in Illumos.
>
> One of the inherited-from-NWS subsystems has an interesting way of working
> either with or without certain state.  Problem is, it calls rw_exit() without
> checking for this state.  Without commenting on the overall architecture,
> I've managed to fix this particular shortcoming.
>
>        http://www.kebe.com/~danmcd/webrevs/935/
>
> I cleaned up the one function a little too w.r.t. cstyle/readability, but the
> important part is not calling rw_exit(0x8) anymore.
>
> Thanks,
> Dan
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer
>



-- 
Adam Leventhal, Delphix
http://dtrace.org/blogs/ahl

275 Middlefield Road, Suite 50
Menlo Park, CA 94025
http://www.delphix.com