[illumos-Developer] CODE REVIEW --> #935, sv_lyr_open() uses NULL pointers...

[Dan McDonald]

On Wed, Apr 20, 2011 at 01:04:16PM -0400, Richard Lowe wrote:
> My only concern, and what I was trying to figure out, is the choice of
> words in the comment.  "Re-acquire" suggests that you have it, and the
> code path assumed that you had it.  I was wondering if the bug was
> reaching into that bit of code _without_ svp, rather than not checking
> whether we had it.

The codepath in question will execute regardless of whether or not svp is
NULL or not.  An svp != NULL check is therefore required.

Dan