[illumos-Developer] [REVIEW] 922 SUNWdtrt needs some love

Garrett D'Amore garrett at damore.org
Wed Apr 20 14:52:28 PDT 2011


tst.include.ksh:  lines 89-90:  We don't have sbpro.h or eri_msg.h
anymore.

The rest looks ok.

	- Garrett

On Wed, 2011-04-20 at 17:39 -0400, Richard Lowe wrote:
> Hey all, I'd like review for:
>   922 SUNWdtrt needs some love
> 
> webrev:
>   http://richlowe.net/webrevs/il_922
> 
> The bug (http://illumos.org/issues/922) contains descriptions of what
> and why, but the one that surprised at least one person was the change
> to fs_reparse.*  'string' is a DTrace keyword, its use here prevents
> DTrace parsing the header.  I decided to remove the use, rather than
> blacklist the header, as it was easy to fix (easier than the __thread
> and __attribute__ cases anyway).
> If anyone can figure out why rds.h uses _both_ of #pragma pack() and
> __attribute__((packed)), they should totally file a bug and fix that
> one, too.
> 
> I plan to push this in the same wad as (most of) Joyent's DTrace
> changes (I fixed these to bring some sanity to making sure I didn't
> damage those while cherry-picking them)
> 
> Thanks,
> 
> -- Rich
> 
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer





More information about the Developer mailing list