[illumos-Developer] [REVIEW] 922 SUNWdtrt needs some love

[Eric Schrock]

Fair enough, looks good to me.

- Eric

On Wed, Apr 20, 2011 at 6:41 PM, Richard Lowe <richlowe at richlowe.net> wrote:
> On Wed, Apr 20, 2011 at 17:49, Eric Schrock <eric.schrock at delphix.com> wrote:
>> In some .ksh places you use:
>>
>>   egrep -w '(ksh|libshell)'
>>
>> While others you use:
>>
>>   egrep '(ksh|libshell\.so\.[0-9])`[a-zA-Z_]'
>>
>> Any particular reason for the disparity?  Otherwise, assuming the
>> dtrace test suite now passes, this look good to me.
>>
>
> The first is just matching on umod, and it seemed reasonable to leave
> it fairly loose.  I thought it best to specify the pattern more fully
> up to the backtick in the cases which have fully qualified symbol
> names.
>
> -- Rich
>



-- 
Eric Schrock
Delphix
275 Middlefield Road, Suite 50
Menlo Park, CA 94025
http://www.delphix.com