[illumos-Developer] [REVIEW] 922 SUNWdtrt needs some love

Richard Lowe richlowe at richlowe.net
Wed Apr 20 15:41:45 PDT 2011


On Wed, Apr 20, 2011 at 17:49, Eric Schrock <eric.schrock at delphix.com> wrote:
> In some .ksh places you use:
>
>   egrep -w '(ksh|libshell)'
>
> While others you use:
>
>   egrep '(ksh|libshell\.so\.[0-9])`[a-zA-Z_]'
>
> Any particular reason for the disparity?  Otherwise, assuming the
> dtrace test suite now passes, this look good to me.
>

The first is just matching on umod, and it seemed reasonable to leave
it fairly loose.  I thought it best to specify the pattern more fully
up to the backtick in the cases which have fully qualified symbol
names.

-- Rich



More information about the Developer mailing list