[illumos-Developer] [REVIEW] 922 SUNWdtrt needs some love

[Eric Schrock]

In some .ksh places you use:

   egrep -w '(ksh|libshell)'

While others you use:

   egrep '(ksh|libshell\.so\.[0-9])`[a-zA-Z_]'

Any particular reason for the disparity?  Otherwise, assuming the
dtrace test suite now passes, this look good to me.

- Eric

On Wed, Apr 20, 2011 at 5:39 PM, Richard Lowe <richlowe at richlowe.net> wrote:
>
> Hey all, I'd like review for:
>  922 SUNWdtrt needs some love
>
> webrev:
>  http://richlowe.net/webrevs/il_922
>
> The bug (http://illumos.org/issues/922) contains descriptions of what
> and why, but the one that surprised at least one person was the change
> to fs_reparse.*  'string' is a DTrace keyword, its use here prevents
> DTrace parsing the header.  I decided to remove the use, rather than
> blacklist the header, as it was easy to fix (easier than the __thread
> and __attribute__ cases anyway).
> If anyone can figure out why rds.h uses _both_ of #pragma pack() and
> __attribute__((packed)), they should totally file a bug and fix that
> one, too.
>
> I plan to push this in the same wad as (most of) Joyent's DTrace
> changes (I fixed these to bring some sanity to making sure I didn't
> damage those while cherry-picking them)
>
> Thanks,
>
> -- Rich
>
> _______________________________________________
> Developer mailing list
> Developer at lists.illumos.org
> http://lists.illumos.org/m/listinfo/developer



--
Eric Schrock
Delphix
275 Middlefield Road, Suite 50
Menlo Park, CA 94025
http://www.delphix.com